-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix onboarding promise #47097
fix onboarding promise #47097
Conversation
@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
src/libs/actions/Welcome.ts
Outdated
@@ -15,6 +15,7 @@ type OnboardingData = Onboarding | [] | undefined; | |||
|
|||
let isLoadingReportData = true; | |||
let tryNewDotData: TryNewDot | undefined; | |||
let onboarding: OnboardingData | undefined; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add my reviewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated.
Hey, I'm thinking that this fix will take care of this issue as well, seems to be related. Could you take a look whenever you have a chance. When I use this branch I get this error but this might have something to do with me locally as it's working for both of you. (Ah I think I might have to disable strict mode) |
Ah yes, disabling strict mode fixed this: OnboardingVideo.movGoing to add this in the list of fixed issues. |
Reviewer Checklist
Screenshots/VideosAndroid: NativeRecord_2024-08-10-01-48-29.mp4Android: mWeb ChromeRecord_2024-08-10-01-50-44.mp4iOS: NativeScreen.Recording.2024-08-10.at.1.39.11.AM.moviOS: mWeb SafariScreen.Recording.2024-08-10.at.1.37.21.AM.movMacOS: Chrome / SafariScreen.Recording.2024-08-10.at.1.31.05.AM.movMacOS: DesktopScreen.Recording.2024-08-10.at.1.54.42.AM-1.mov |
This comment was marked as resolved.
This comment was marked as resolved.
Oh so i have to disable Strict mode, to make it work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review @ishpaul777! This looks good to me from before. @NikkiWines if you want to take a final pass at this or we can merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great 🎊
Screen.Recording.2024-08-09.at.22.43.59.mov
fix onboarding promise (cherry picked from commit ad59bf3) (CP triggered by marcaaron)
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Cherry-picked to staging by https://github.com/OSBotify in version: 9.0.18-10 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Details
fix onboarding promise
Fixed Issues
$ #47054
$ #47157
PROPOSAL:
Tests
Offline tests
None
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Screen.Recording.2024-08-08.at.23.56.40.mov
Android: mWeb Chrome
Screen.Recording.2024-08-08.at.23.54.11.mov
iOS: Native
Screen.Recording.2024-08-08.at.23.57.34.mov
iOS: mWeb Safari
Screen.Recording.2024-08-08.at.23.55.38.mov
MacOS: Chrome / Safari
Screen.Recording.2024-08-08.at.23.53.02.mov
MacOS: Desktop
Screen.Recording.2024-08-09.at.00.01.10.mp4